docs(firestore): Add docs on Firestore x SPM integration #15387
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
|
/gemini review These docs are meant to educate repo maintainers on the organization of the Firestore-related targets in the Package.swift |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds excellent documentation explaining the complex Swift Package Manager target hierarchy for Firestore. The document is well-structured and clearly explains the different build options (binary, source, and CI-local) and the testing setup. I have a couple of minor suggestions to improve consistency and clarity in the dependency diagrams and target descriptions. Overall, this is a great addition that will be very helpful for developers.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
daymxn
dismissed
their stale review
Changing to a comment instead of a +2, so you can enable auto merge and have @cherylEnkidu approve it instead
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces excellent documentation for the Firestore Swift Package Manager integration. The new FirestoreSPM.md file clearly explains the different build options and the target hierarchy, which will be a great resource for developers. The changes are well-written and accurate. I have one minor suggestion to improve the wording for readability.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
The Firestore bits of the Package.swift are justifiably complicated. I vibe coded these docs to explain the current state.
cc: @rafikhan
#no-changelog